Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1243543002: Fix incorrect usage of the RETURN_ON_FAILURE and RETURN_ON_HR_FAILURE macros in the CreateCOMObject… (Closed)

Created:
5 years, 5 months ago by ananta
Modified:
5 years, 5 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix incorrect usage of the RETURN_ON_FAILURE and RETURN_ON_HR_FAILURE macros in the CreateCOMObjectFromDll function in dxva. We were returning false on failure which in HRESULT terms is a success code (S_OK). BUG=511044 Committed: https://crrev.com/842c8f9ecb6fd5faf0bdfd7690d94e7d41188c57 Cr-Commit-Position: refs/heads/master@{#339205}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/common/gpu/media/dxva_video_decode_accelerator.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1009683002 Patch 1

Messages

Total messages: 7 (2 generated)
ananta
5 years, 5 months ago (2015-07-17 01:46:41 UTC) #2
DaleCurtis
lgtm
5 years, 5 months ago (2015-07-17 01:47:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1243543002/1
5 years, 5 months ago (2015-07-17 01:50:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-17 02:41:09 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-17 02:42:02 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/842c8f9ecb6fd5faf0bdfd7690d94e7d41188c57
Cr-Commit-Position: refs/heads/master@{#339205}

Powered by Google App Engine
This is Rietveld 408576698