chrome/install_static/BUILD.gn - Issue 2017853002: Add functionality to the install_static library to tokenize strings and compare versions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/install_static/BUILD.gn

Issue 2017853002: Add functionality to the install_static library to tokenize strings and compare versions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add install_static_unittests to other windows bots Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/chrome_installer_static.gypi ('k') | chrome/install_static/install_static_unittests.isolate » ('j') | testing/buildbot/chromium_trybot.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/install_static/BUILD.gn

diff --git a/chrome/install_static/BUILD.gn b/chrome/install_static/BUILD.gn

index 14d875e0b33df4184e7ac06997ddf0d3ca7b91ae..ec8ff5f6f49f43c188f1484cf7662d82a8c3179c 100644

--- a/chrome/install_static/BUILD.gn

+++ b/chrome/install_static/BUILD.gn

@@ -29,3 +29,19 @@ static_library("install_static_util") {

"//build/config/compiler:no_size_t_to_int_warning",

]

}

+test("install_static_unittests") {

+ output_name = "install_static_unittests"

Dirk Pranke 2016/05/31 22:11:54 output_name isn't needed here.

+ sources = [

+ "install_util_unittest.cc",

+ ]

+ include_dirs = [ "$target_gen_dir" ]

Dirk Pranke 2016/05/31 22:11:54 this shouldn't be needed, either.

+ deps = [

+ "//base",

+ "//base/test:run_all_unittests",

+ "//base/test:test_support",

+ "//chrome/install_static:install_static_util",

+ "//testing/gmock",

+ "//testing/gtest",

+ ]

« no previous file with comments | « chrome/chrome_installer_static.gypi ('k') | chrome/install_static/install_static_unittests.isolate » ('j') | testing/buildbot/chromium_trybot.json » ('J')