Remove FilePath usage from the CrashReporterClient interface on Windows.

chrome/installer/setup/installer_crash_reporter_client.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/installer/setup/installer_crash_reporter_client.h"
 
 #include "base/debug/crash_logging.h"
 #include "base/environment.h"
 #include "base/file_version_info.h"
+#include "base/files/file_path.h"
 #include "base/path_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/win/registry.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_version.h"
 #include "chrome/common/env_vars.h"
 #include "chrome/installer/setup/installer_crash_reporting.h"
 #include "chrome/installer/util/google_update_settings.h"
 
 InstallerCrashReporterClient::InstallerCrashReporterClient(
     bool is_per_user_install)
     : is_per_user_install_(is_per_user_install) {
 }
 
 InstallerCrashReporterClient::~InstallerCrashReporterClient() = default;
 
 bool InstallerCrashReporterClient::ShouldCreatePipeName(
     const base::string16& process_type) {
   return true;
 }
 
 bool InstallerCrashReporterClient::GetAlternativeCrashDumpLocation(
-    base::FilePath* crash_dir) {
+    base::string16* crash_dir) {
   return false;
 }
 
 void InstallerCrashReporterClient::GetProductNameAndVersion(
-    const base::FilePath& exe_path,
+    const base::string16& exe_path,
     base::string16* product_name,
     base::string16* version,
     base::string16* special_build,
     base::string16* channel_name) {
   // Report crashes under the same product name as the browser. This string
   // MUST match server-side configuration.
   *product_name = base::ASCIIToUTF16(PRODUCT_SHORTNAME_STRING);
 
   std::unique_ptr<FileVersionInfo> version_info(
-      FileVersionInfo::CreateFileVersionInfo(exe_path));
+      FileVersionInfo::CreateFileVersionInfo(base::FilePath(exe_path)));
   if (version_info) {
     *version = version_info->product_version();
     *special_build = version_info->special_build();
   } else {
     *version = L"0.0.0.0-devel";
   }
 
   GoogleUpdateSettings::GetChromeChannelAndModifiers(
       !GetIsPerUserInstall(exe_path), channel_name);
 }
@@ skipping 11 matching lines @@
   return false;
 }
 
 bool InstallerCrashReporterClient::GetDeferredUploadsSupported(
     bool is_per_user_install) {
   // Copy Chrome's impl?
   return false;
 }
 
 bool InstallerCrashReporterClient::GetIsPerUserInstall(
-    const base::FilePath& exe_path) {
+    const base::string16& exe_path) {
   return is_per_user_install_;
 }
 
 bool InstallerCrashReporterClient::GetShouldDumpLargerDumps(
     bool is_per_user_install) {
   DCHECK_EQ(is_per_user_install_, is_per_user_install);
   base::string16 channel =
       GoogleUpdateSettings::GetChromeChannel(!is_per_user_install);
   // Use large dumps for all but the stable channel.
   return !channel.empty();
 }
 
 int InstallerCrashReporterClient::GetResultCodeRespawnFailed() {
   // The restart dialog is never shown for the installer.
   NOTREACHED();
   return 0;
 }
 
 bool InstallerCrashReporterClient::GetCrashDumpLocation(
-    base::FilePath* crash_dir) {
-  return PathService::Get(chrome::DIR_CRASH_DUMPS, crash_dir);
+    base::string16* crash_dir) {
+  base::FilePath crash_directory_path;
+  bool ret = PathService::Get(chrome::DIR_CRASH_DUMPS, &crash_directory_path);
+  if (ret)
+    *crash_dir = crash_directory_path.value();
+  return ret;
 }
 
 size_t InstallerCrashReporterClient::RegisterCrashKeys() {
   return installer::RegisterCrashKeys();
 }
 
 bool InstallerCrashReporterClient::IsRunningUnattended() {
   std::unique_ptr<base::Environment> env(base::Environment::Create());
   return env->HasVar(env_vars::kHeadless);
 }
@@ skipping 36 matching lines @@
     }
   }
 
   return false;
 }
 
 bool InstallerCrashReporterClient::EnableBreakpadForProcess(
     const std::string& process_type) {
   return true;
 }