chrome_elf/chrome_elf.gyp - Issue 2077323004: Remove dependency on base/win/win_util.cc from crashpad.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_elf/chrome_elf.gyp

Issue 2077323004: Remove dependency on base/win/win_util.cc from crashpad. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments and update patch description Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome_elf/chrome_elf.gyp

diff --git a/chrome_elf/chrome_elf.gyp b/chrome_elf/chrome_elf.gyp

index 034476a6568d865848c9ab957e793ab99fa4c2c8..87d16f22a754d772bcfe4ce02468b99c535e8eda 100644

--- a/chrome_elf/chrome_elf.gyp

+++ b/chrome_elf/chrome_elf.gyp

@@ -37,6 +37,8 @@

'chrome_elf.def',

'chrome_elf_main.cc',

'chrome_elf_main.h',

+ '../chrome/app/chrome_crash_reporter_client_win.cc',

+ '../chrome/app/chrome_crash_reporter_client_win.h',

'<(SHARED_INTERMEDIATE_DIR)/chrome_elf/chrome_elf_version.rc',

'dependencies': [

@@ -44,6 +46,8 @@

'chrome_elf_breakpad',

'chrome_elf_resources',

'../chrome/chrome.gyp:install_static_util',

+ '../components/components.gyp:crash_component',

+ '../components/components.gyp:crash_core_common',

'msvs_settings': {

'VCLinkerTool': {

« no previous file with comments | « chrome_elf/DEPS ('k') | chrome_elf/elf_imports_unittest.cc » ('j') | no next file with comments »