Avoid using ContentBrowserClient::IsIllegalOrigin in ResourceDispatcherHost.

chrome/browser/extensions/extension_system_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_system_impl.h"
 
 #include <algorithm>
 
 #include "base/base_switches.h"
 #include "base/bind.h"
@@ skipping 20 matching lines @@
 #include "chrome/browser/extensions/shared_module_service.h"
 #include "chrome/browser/extensions/shared_user_script_master.h"
 #include "chrome/browser/extensions/state_store_notification_observer.h"
 #include "chrome/browser/extensions/unpacked_installer.h"
 #include "chrome/browser/extensions/update_install_gate.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/webui/extensions/extension_icon_source.h"
 #include "chrome/common/chrome_switches.h"
 #include "content/public/browser/browser_thread.h"
+#include "content/public/browser/resource_dispatcher_host.h"
 #include "content/public/browser/url_data_source.h"
 #include "extensions/browser/content_verifier.h"
 #include "extensions/browser/extension_pref_store.h"
 #include "extensions/browser/extension_pref_value_map.h"
 #include "extensions/browser/extension_pref_value_map_factory.h"
 #include "extensions/browser/extension_prefs.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/info_map.h"
 #include "extensions/browser/quota_service.h"
 #include "extensions/browser/runtime_data.h"
 #include "extensions/browser/service_worker_manager.h"
 #include "extensions/browser/state_store.h"
 #include "extensions/browser/uninstall_ping_sender.h"
 #include "extensions/browser/value_store/value_store_factory_impl.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/features/feature_channel.h"
+#include "extensions/common/manifest_constants.h"
 #include "extensions/common/manifest_url_handlers.h"
 
 #if defined(ENABLE_NOTIFICATIONS)
 #include "chrome/browser/notifications/notifier_state_tracker.h"
 #include "chrome/browser/notifications/notifier_state_tracker_factory.h"
 #include "ui/message_center/notifier_settings.h"
 #endif
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/app_mode/app_mode_utils.h"
@@ skipping 16 matching lines @@
 UninstallPingSender::FilterResult ShouldSendUninstallPing(
     const Extension* extension,
     UninstallReason reason) {
   if (extension && (extension->from_webstore() ||
                     ManifestURL::UpdatesFromGallery(extension))) {
     return UninstallPingSender::SEND_PING;
   }
   return UninstallPingSender::DO_NOT_SEND_PING;
 }
 
+// Helper functions to register and unregister extensions. These are invoked
+// on the IO thread.
+void RegisterExtensionHelper(InfoMap* info_map,
+                             const Extension* extension,
+                             base::Time install_time,
+                             bool incognito_enabled,
+                             bool notifications_disabled,
+                             const content::ResourceContext* context) {
+  DCHECK_CURRENTLY_ON(BrowserThread::IO);
+
+  info_map->AddExtension(extension, install_time, incognito_enabled,
+    notifications_disabled);
+  // Check for platform app origins.  These can only be committed by the app
+  // itself, or by one if its guests if there are accessible_resources.
+  // If the origin is not a platform app, then we assume all processes can
+  // commit to it as we don't have enough information to validate it. This
+  // includes hosted apps and normal extensions.
+  content::ResourceDispatcherHost::OriginAccessCheckMask access_check_mask =
+      content::ResourceDispatcherHost::ALLOW_EVERYTHING;
+  if (extension->is_platform_app() && !!extension->GetManifestData(
+      manifest_keys::kWebviewAccessibleResources)) {
+    access_check_mask =
+        content::ResourceDispatcherHost::ALLOW_REGISTERED_ACCESS;
+  }
+  content::ResourceDispatcherHost::Get()->RegisterOriginForAccessChecks(
+      context, Extension::GetBaseURLFromExtensionId(extension->id()).spec(),
+      access_check_mask);
+}
+
+void UnregisterExtensionHelper(InfoMap* info_map,
+                               const std::string& extension_id,
+                               const UnloadedExtensionInfo::Reason reason,
+                               const content::ResourceContext* context) {
+  DCHECK_CURRENTLY_ON(BrowserThread::IO);
+
+  info_map->RemoveExtension(extension_id, reason);
+  content::ResourceDispatcherHost::Get()->UnregisterOriginForAccessChecks(
+    context, Extension::GetBaseURLFromExtensionId(extension_id).spec());
+}
+
 }  // namespace
 
 //
 // ExtensionSystemImpl::Shared
 //
 
 ExtensionSystemImpl::Shared::Shared(Profile* profile)
     : profile_(profile) {
 }
 
@@ skipping 347 matching lines @@
       extension->id());
 
   NotifierStateTracker* notifier_state_tracker =
       NotifierStateTrackerFactory::GetForProfile(profile_);
   notifications_disabled =
       !notifier_state_tracker->IsNotifierEnabled(notifier_id);
 #endif
 
   BrowserThread::PostTaskAndReply(
       BrowserThread::IO, FROM_HERE,
-      base::Bind(&InfoMap::AddExtension, info_map(),
+      base::Bind(&RegisterExtensionHelper, base::RetainedRef(info_map()),
                  base::RetainedRef(extension), install_time, incognito_enabled,
-                 notifications_disabled),
+                 notifications_disabled, profile_->GetResourceContext()),
       callback);
 }
 
 void ExtensionSystemImpl::UnregisterExtensionWithRequestContexts(
     const std::string& extension_id,
     const UnloadedExtensionInfo::Reason reason) {
   BrowserThread::PostTask(
       BrowserThread::IO,
       FROM_HERE,
-      base::Bind(&InfoMap::RemoveExtension, info_map(), extension_id, reason));
+      base::Bind(&UnregisterExtensionHelper, base::RetainedRef(info_map()),
+                 extension_id, reason, profile_->GetResourceContext()));
 }
 
 }  // namespace extensions