chrome/browser/chrome_content_browser_client.cc - Issue 2182633007: Avoid using ContentBrowserClient::IsIllegalOrigin in ResourceDispatcherHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 2182633007: Avoid using ContentBrowserClient::IsIllegalOrigin in ResourceDispatcherHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove the IsIllegalOrigin function from ContentBrowserClient Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chrome_content_browser_client.h ('k') | chrome/browser/extensions/chrome_content_browser_client_extensions_part.h » ('j') | content/browser/loader/resource_dispatcher_host_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chrome_content_browser_client.cc

diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc

index eaca7ab8535af3b4b6ab4d03014c4dc138e2efa2..9bae1ee296c667e15ffad9a8150ae86ecba9a288 100644

--- a/chrome/browser/chrome_content_browser_client.cc

+++ b/chrome/browser/chrome_content_browser_client.cc

@@ -1134,18 +1134,6 @@ bool ChromeContentBrowserClient::CanCommitURL(

#endif

}

-bool ChromeContentBrowserClient::IsIllegalOrigin(

- content::ResourceContext* resource_context,

- int child_process_id,

- const GURL& origin) {

-#if defined(ENABLE_EXTENSIONS)

- return ChromeContentBrowserClientExtensionsPart::IsIllegalOrigin(

- resource_context, child_process_id, origin);

-#else

- return false;

-#endif

bool ChromeContentBrowserClient::ShouldAllowOpenURL(

content::SiteInstance* site_instance, const GURL& url) {

GURL from_url = site_instance->GetSiteURL();