content/public/browser/content_browser_client.cc - Issue 2182633007: Avoid using ContentBrowserClient::IsIllegalOrigin in ResourceDispatcherHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/content_browser_client.cc

Issue 2182633007: Avoid using ContentBrowserClient::IsIllegalOrigin in ResourceDispatcherHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove the IsIllegalOrigin function from ContentBrowserClient Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/loader/resource_dispatcher_host_impl.h ('K') | « content/public/browser/content_browser_client.h ('k') | content/public/browser/resource_dispatcher_host.h » ('j') | content/public/browser/resource_dispatcher_host.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/content_browser_client.cc

diff --git a/content/public/browser/content_browser_client.cc b/content/public/browser/content_browser_client.cc

index e78e78a52091046836870a95495b54b0e204a8f9..ac7be8809926cbe7843338e0057c6c34f477a767 100644

--- a/content/public/browser/content_browser_client.cc

+++ b/content/public/browser/content_browser_client.cc

@@ -72,12 +72,6 @@ bool ContentBrowserClient::CanCommitURL(RenderProcessHost* process_host,

return true;

}

-bool ContentBrowserClient::IsIllegalOrigin(ResourceContext* resource_context,

- int child_process_id,

- const GURL& origin) {

- return false;

bool ContentBrowserClient::ShouldAllowOpenURL(SiteInstance* site_instance,

const GURL& url) {

return true;