Remove FilePath usage from the CrashReporterClient interface on Windows.

Remove FilePath usage from the CrashReporterClient interface on Windows.

The CrashReporterClient implementation on Windows which is implemented by
the ChromeCrashReporterClient class will eventually move into chrome_elf
which loads very early in the chrome process. This requires it to not
depend on anything other than kernel32.dll and advapi32.dll.

Depending on base::FilePath pulls in FileUtil which on Windows brings with
it dependencies on message loop etc which won't work in chrome_elf.
Additionally the ChromeCrashReporterClient class currently depends on
content for constants, etc.

I defined these constants in the install_static library along with TODOs
to unify them. I plan to do that after finishing up the work for
chrome_elf.

The changes in this patch are as below:-
1. Remove FilePath from the CrashReporterClient functions on Windows.
2. Use the constants from install_static instead of those from content
   and base::Env.
3. Remove usage of base::Version from ChromeCrashReporterClient as that
   pulls in base logging which is not good for us.
4. Replace DCHECKs with asserts in ChromeCrashReporterClient

BUG=604923
Committed: https://crrev.com/e76a92ef5942fe99139ae02e7dc5162dc0b24358
Cr-Commit-Position: refs/heads/master@{#397865}

[ananta, 2016-06-01 21:39:22]

ananta@chromium.org changed reviewers:
+ scottmg@chromium.org

[ananta, 2016-06-01 21:39:46]

ananta@chromium.org changed reviewers:
+ grt@chromium.org

[ananta, 2016-06-01 21:39:46]

+grt for install_util changes.

[scottmg, 2016-06-02 00:01:13]

https://codereview.chromium.org/2031833002/diff/40001/chrome/app/chrome_crash...
File chrome/app/chrome_crash_reporter_client_win.h (right):

https://codereview.chromium.org/2031833002/diff/40001/chrome/app/chrome_crash...
chrome/app/chrome_crash_reporter_client_win.h:11: class
ChromeCrashReporterClient : public crash_reporter::CrashReporterClient {
You're going to have to change all platforms that implement this, aren't you?

[scottmg, 2016-06-02 00:01:59]

On 2016/06/02 00:01:13, scottmg wrote:
>
https://codereview.chromium.org/2031833002/diff/40001/chrome/app/chrome_crash...
> File chrome/app/chrome_crash_reporter_client_win.h (right):
> 
>
https://codereview.chromium.org/2031833002/diff/40001/chrome/app/chrome_crash...
> chrome/app/chrome_crash_reporter_client_win.h:11: class
> ChromeCrashReporterClient : public crash_reporter::CrashReporterClient {
> You're going to have to change all platforms that implement this, aren't you?

Oh, sorry, I didn't see the #ifdefs in the header. Looking more...

[scottmg, 2016-06-02 00:09:30]

The string16 stuff seems ok to me, I'm not too excited about the copy of the
constants. What's the plan for how we'll remove the duplication?

https://codereview.chromium.org/2031833002/diff/40001/chrome/install_static/i...
File chrome/install_static/install_util.h (right):

https://codereview.chromium.org/2031833002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.h:47: // http://crbug.com/604923
Use https://... (and below).

https://codereview.chromium.org/2031833002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.h:57: // Unify these constants with those
defiend in content_switches.h.
defined

https://codereview.chromium.org/2031833002/diff/40001/content/shell/app/shell...
File content/shell/app/shell_crash_reporter_client.cc (right):

https://codereview.chromium.org/2031833002/diff/40001/content/shell/app/shell...
content/shell/app/shell_crash_reporter_client.cc:66: switches::kCrashDumpsDir);
can you just #if the signature and the .value() instead of copying the whole
thing?

[scottmg, 2016-06-02 00:10:06]

Oh, could you confirm that assert() really gets compiled out in Release builds
of chrome_elf too? :)

[ananta, 2016-06-02 00:22:57]

I was thinking about putting these constants in a common place which does not
link to anything. Need to discuss with jam.

https://codereview.chromium.org/2031833002/diff/40001/chrome/install_static/i...
File chrome/install_static/install_util.h (right):

https://codereview.chromium.org/2031833002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.h:47: // http://crbug.com/604923
On 2016/06/02 00:09:30, scottmg wrote:
> Use https://... (and below).

Done.

https://codereview.chromium.org/2031833002/diff/40001/chrome/install_static/i...
chrome/install_static/install_util.h:57: // Unify these constants with those
defiend in content_switches.h.
On 2016/06/02 00:09:30, scottmg wrote:
> defined

done

https://codereview.chromium.org/2031833002/diff/40001/content/shell/app/shell...
File content/shell/app/shell_crash_reporter_client.cc (right):

https://codereview.chromium.org/2031833002/diff/40001/content/shell/app/shell...
content/shell/app/shell_crash_reporter_client.cc:66: switches::kCrashDumpsDir);
On 2016/06/02 00:09:30, scottmg wrote:
> can you just #if the signature and the .value() instead of copying the whole
> thing?

Done.

[ananta, 2016-06-02 00:31:21]

On 2016/06/02 00:10:06, scottmg wrote:
> Oh, could you confirm that assert() really gets compiled out in Release builds
> of chrome_elf too? :)

I think so. Will double check

[grt (UTC plus 2), 2016-06-02 12:55:33]

https://codereview.chromium.org/2031833002/diff/80001/chrome/app/chrome_crash...
File chrome/app/chrome_crash_reporter_client_win.cc (right):

https://codereview.chromium.org/2031833002/diff/80001/chrome/app/chrome_crash...
chrome/app/chrome_crash_reporter_client_win.cc:39: *crash_dir =
install_static::UTF8ToUTF16(alternate_crash_dump_location);
GetEnvironmentString does a UTF16ToUTF8 under the covers. how about making it
return a base::string16 from the get-go on windows, and require that other
consumers do the conversion? or add a second GetEnvironmentString that doesn't
do the conversion

https://codereview.chromium.org/2031833002/diff/80001/chrome/app/chrome_crash...
chrome/app/chrome_crash_reporter_client_win.cc:69:
install_static::GetEnvironmentString(install_static::kRestartInfo);
another spot where a string16 GetEnvironmentString makes sense

https://codereview.chromium.org/2031833002/diff/80001/chrome/app/chrome_crash...
chrome/app/chrome_crash_reporter_client_win.cc:94: bool
ChromeCrashReporterClient::GetDeferredUploadsSupported(
i was under the impression that this feature never launched. i can find no code
that calls this function. could you make this "return false;" and then remove
the function from the interface and all impls in a different CL?

https://codereview.chromium.org/2031833002/diff/80001/chrome/install_static/i...
File chrome/install_static/install_util.h (right):

https://codereview.chromium.org/2031833002/diff/80001/chrome/install_static/i...
chrome/install_static/install_util.h:62: extern const char kZygoteProcess[];
this constant is only used on linux, no? is this a cross-platform file?

https://codereview.chromium.org/2031833002/diff/80001/components/crash/conten...
File components/crash/content/app/crashpad_win.cc (right):

https://codereview.chromium.org/2031833002/diff/80001/components/crash/conten...
components/crash/content/app/crashpad_win.cc:69:
crash_reporter_client->GetCrashDumpLocation(&database_path_str);
    if (crash_reporter_client->GetCrashDumpLocation(&database_path_str))
      database_path = base::FilePath(database_path_str);

https://codereview.chromium.org/2031833002/diff/80001/content/shell/app/shell...
File content/shell/app/shell_crash_reporter_client.cc (right):

https://codereview.chromium.org/2031833002/diff/80001/content/shell/app/shell...
content/shell/app/shell_crash_reporter_client.cc:65: *crash_dir =
crash_directory;
#include <utility>
 *crash_dir = std::move(crash_directory);

[ananta, 2016-06-02 20:34:20]

https://codereview.chromium.org/2031833002/diff/80001/chrome/app/chrome_crash...
File chrome/app/chrome_crash_reporter_client_win.cc (right):

https://codereview.chromium.org/2031833002/diff/80001/chrome/app/chrome_crash...
chrome/app/chrome_crash_reporter_client_win.cc:39: *crash_dir =
install_static::UTF8ToUTF16(alternate_crash_dump_location);
On 2016/06/02 12:55:33, grt (slow) wrote:
> GetEnvironmentString does a UTF16ToUTF8 under the covers. how about making it
> return a base::string16 from the get-go on windows, and require that other
> consumers do the conversion? or add a second GetEnvironmentString that doesn't
> do the conversion

Done. Added GetEnvironmentString16, SetEnvironmentString16 and
HasEnvironmentVariable16 for symmetry.

https://codereview.chromium.org/2031833002/diff/80001/chrome/app/chrome_crash...
chrome/app/chrome_crash_reporter_client_win.cc:69:
install_static::GetEnvironmentString(install_static::kRestartInfo);
On 2016/06/02 12:55:33, grt (slow) wrote:
> another spot where a string16 GetEnvironmentString makes sense

Done.

https://codereview.chromium.org/2031833002/diff/80001/chrome/app/chrome_crash...
chrome/app/chrome_crash_reporter_client_win.cc:94: bool
ChromeCrashReporterClient::GetDeferredUploadsSupported(
On 2016/06/02 12:55:33, grt (slow) wrote:
> i was under the impression that this feature never launched. i can find no
code
> that calls this function. could you make this "return false;" and then remove
> the function from the interface and all impls in a different CL?

Done.

https://codereview.chromium.org/2031833002/diff/80001/chrome/install_static/i...
File chrome/install_static/install_util.h (right):

https://codereview.chromium.org/2031833002/diff/80001/chrome/install_static/i...
chrome/install_static/install_util.h:62: extern const char kZygoteProcess[];
On 2016/06/02 12:55:33, grt (slow) wrote:
> this constant is only used on linux, no? is this a cross-platform file?

It is not. However initially it was. Removed the constant.

https://codereview.chromium.org/2031833002/diff/80001/components/crash/conten...
File components/crash/content/app/crashpad_win.cc (right):

https://codereview.chromium.org/2031833002/diff/80001/components/crash/conten...
components/crash/content/app/crashpad_win.cc:69:
crash_reporter_client->GetCrashDumpLocation(&database_path_str);
On 2016/06/02 12:55:33, grt (slow) wrote:
>     if (crash_reporter_client->GetCrashDumpLocation(&database_path_str))
>       database_path = base::FilePath(database_path_str);

Done.

https://codereview.chromium.org/2031833002/diff/80001/content/shell/app/shell...
File content/shell/app/shell_crash_reporter_client.cc (right):

https://codereview.chromium.org/2031833002/diff/80001/content/shell/app/shell...
content/shell/app/shell_crash_reporter_client.cc:65: *crash_dir =
crash_directory;
On 2016/06/02 12:55:33, grt (slow) wrote:
> #include <utility>
>  *crash_dir = std::move(crash_directory);

Done. Left the OS_WIN part as is

[ananta, 2016-06-02 20:37:31]

Added couple tests for TokenizeString16.

[scottmg, 2016-06-02 22:01:49]

lgtm

https://codereview.chromium.org/2031833002/diff/120001/chrome/app/chrome_cras...
File chrome/app/chrome_crash_reporter_client_win.cc (right):

https://codereview.chromium.org/2031833002/diff/120001/chrome/app/chrome_cras...
chrome/app/chrome_crash_reporter_client_win.cc:73: restart_info, L'|', true); //
true = Trim shitespace.
"whitespace" (two spaces before // too)

[grt (UTC plus 2), 2016-06-02 22:57:44]

https://codereview.chromium.org/2031833002/diff/80001/chrome/app/chrome_crash...
File chrome/app/chrome_crash_reporter_client_win.cc (right):

https://codereview.chromium.org/2031833002/diff/80001/chrome/app/chrome_crash...
chrome/app/chrome_crash_reporter_client_win.cc:94: bool
ChromeCrashReporterClient::GetDeferredUploadsSupported(
On 2016/06/02 20:34:20, ananta wrote:
> On 2016/06/02 12:55:33, grt (slow) wrote:
> > i was under the impression that this feature never launched. i can find no
> code
> > that calls this function. could you make this "return false;" and then
remove
> > the function from the interface and all impls in a different CL?
> 
> Done.

Thanks. scottmg: could you confirm that my read is correct?

https://codereview.chromium.org/2031833002/diff/120001/chrome/app/chrome_cras...
File chrome/app/chrome_crash_reporter_client_win.cc (right):

https://codereview.chromium.org/2031833002/diff/120001/chrome/app/chrome_cras...
chrome/app/chrome_crash_reporter_client_win.cc:38: return !!crash_dir->empty();
I think you have one too many !s here, no?

https://codereview.chromium.org/2031833002/diff/120001/chrome/app/chrome_cras...
chrome/app/chrome_crash_reporter_client_win.cc:73: restart_info, L'|', true); //
true = Trim shitespace.
On 2016/06/02 22:01:49, scottmg (ooo june 3rd) wrote:
> "whitespace" (two spaces before // too)

I totally prefer the original comment.

https://codereview.chromium.org/2031833002/diff/120001/chrome/install_static/...
File chrome/install_static/install_util.cc (right):

https://codereview.chromium.org/2031833002/diff/120001/chrome/install_static/...
chrome/install_static/install_util.cc:431: DelimiterType delimiter,
Can you do away with this template arg and use typename StringType::value_type
here (value_type may be the wrong name, but I think basic_string has a typedef
for the char type)?

[scottmg, 2016-06-02 23:01:09]

https://codereview.chromium.org/2031833002/diff/80001/chrome/app/chrome_crash...
File chrome/app/chrome_crash_reporter_client_win.cc (right):

https://codereview.chromium.org/2031833002/diff/80001/chrome/app/chrome_crash...
chrome/app/chrome_crash_reporter_client_win.cc:94: bool
ChromeCrashReporterClient::GetDeferredUploadsSupported(
On 2016/06/02 22:57:44, grt (slow) wrote:
> On 2016/06/02 20:34:20, ananta wrote:
> > On 2016/06/02 12:55:33, grt (slow) wrote:
> > > i was under the impression that this feature never launched. i can find no
> > code
> > > that calls this function. could you make this "return false;" and then
> remove
> > > the function from the interface and all impls in a different CL?
> > 
> > Done.
> 
> Thanks. scottmg: could you confirm that my read is correct?

Yeah, I agree. I have no idea what that is, and it doesn't seem to be used.

[ananta, 2016-06-02 23:10:30]

https://codereview.chromium.org/2031833002/diff/120001/chrome/app/chrome_cras...
File chrome/app/chrome_crash_reporter_client_win.cc (right):

https://codereview.chromium.org/2031833002/diff/120001/chrome/app/chrome_cras...
chrome/app/chrome_crash_reporter_client_win.cc:38: return !!crash_dir->empty();
On 2016/06/02 22:57:44, grt (slow) wrote:
> I think you have one too many !s here, no?

Yes. Thanks for catching. Was not thinking when I wrote this.

https://codereview.chromium.org/2031833002/diff/120001/chrome/app/chrome_cras...
chrome/app/chrome_crash_reporter_client_win.cc:73: restart_info, L'|', true); //
true = Trim shitespace.
On 2016/06/02 22:01:49, scottmg (ooo june 3rd) wrote:
> "whitespace" (two spaces before // too)

Done.

https://codereview.chromium.org/2031833002/diff/120001/chrome/app/chrome_cras...
chrome/app/chrome_crash_reporter_client_win.cc:73: restart_info, L'|', true); //
true = Trim shitespace.
On 2016/06/02 22:57:44, grt (slow) wrote:
> On 2016/06/02 22:01:49, scottmg (ooo june 3rd) wrote:
> > "whitespace" (two spaces before // too)
> 
> I totally prefer the original comment.
Point taken in jest

https://codereview.chromium.org/2031833002/diff/120001/chrome/install_static/...
File chrome/install_static/install_util.cc (right):

https://codereview.chromium.org/2031833002/diff/120001/chrome/install_static/...
chrome/install_static/install_util.cc:431: DelimiterType delimiter,
On 2016/06/02 22:57:44, grt (slow) wrote:
> Can you do away with this template arg and use typename StringType::value_type
> here (value_type may be the wrong name, but I think basic_string has a typedef
> for the char type)?

Done.

[grt (UTC plus 2), 2016-06-03 15:41:41]

lgtm

https://codereview.chromium.org/2031833002/diff/160001/chrome/install_static/...
File chrome/install_static/install_util.cc (right):

https://codereview.chromium.org/2031833002/diff/160001/chrome/install_static/...
chrome/install_static/install_util.cc:435:
std::basic_istringstream<StringType::value_type> buffer(str);
clang says you need "typename" here, too. how nice of it. :-)

[ananta, 2016-06-03 22:32:07]

https://codereview.chromium.org/2031833002/diff/160001/chrome/install_static/...
File chrome/install_static/install_util.cc (right):

https://codereview.chromium.org/2031833002/diff/160001/chrome/install_static/...
chrome/install_static/install_util.cc:435:
std::basic_istringstream<StringType::value_type> buffer(str);
On 2016/06/03 15:41:41, grt (slow) wrote:
> clang says you need "typename" here, too. how nice of it. :-)

Done.

[ananta, 2016-06-03 22:33:15]

The CQ bit was checked by ananta@chromium.org

[ananta, 2016-06-03 22:33:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
scottmg@chromium.org, grt@chromium.org
Link to the patchset: https://codereview.chromium.org/2031833002/#ps240001
(title: "Remove unused constant to fix clang")

[commit-bot: I haz the power, 2016-06-03 22:33:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2031833002/240001

[commit-bot: I haz the power, 2016-06-03 22:42:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 22:42:02]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ananta, 2016-06-03 22:47:41]

Description was changed from

==========
Remove FilePath usage from the CrashReporterClient interface on Windows.

The CrashReporterClient implementation on Windows which is implemented by
the ChromeCrashReporterClient class will eventually move into chrome_elf
which loads very early in the chrome process. This requires it to not
depend on anything other than kernel32.dll and advapi32.dll.

Depending on base::FilePath pulls in FileUtil which on Windows brings with
it dependencies on message loop etc which won't work in chrome_elf.
Additionally the ChromeCrashReporterClient class currently depends on
content for constants, etc.

I defined these constants in the install_static library along with TODOs
to unify them. I plan to do that after finishing up the work for
chrome_elf.

The changes in this patch are as below:-
1. Remove FilePath from the CrashReporterClient functions on Windows.
2. Use the constants from install_static instead of those from content
   and base::Env.
3. Remove usage of base::Version from ChromeCrashReporterClient as that
   pulls in base logging which is not good for us.
4. Replace DCHECKs with asserts in ChromeCrashReporterClient

BUG=604923
==========

to

==========
Remove FilePath usage from the CrashReporterClient interface on Windows.

The CrashReporterClient implementation on Windows which is implemented by
the ChromeCrashReporterClient class will eventually move into chrome_elf
which loads very early in the chrome process. This requires it to not
depend on anything other than kernel32.dll and advapi32.dll.

Depending on base::FilePath pulls in FileUtil which on Windows brings with
it dependencies on message loop etc which won't work in chrome_elf.
Additionally the ChromeCrashReporterClient class currently depends on
content for constants, etc.

I defined these constants in the install_static library along with TODOs
to unify them. I plan to do that after finishing up the work for
chrome_elf.

The changes in this patch are as below:-
1. Remove FilePath from the CrashReporterClient functions on Windows.
2. Use the constants from install_static instead of those from content
   and base::Env.
3. Remove usage of base::Version from ChromeCrashReporterClient as that
   pulls in base logging which is not good for us.
4. Replace DCHECKs with asserts in ChromeCrashReporterClient

BUG=604923
==========

[ananta, 2016-06-03 22:47:41]

ananta@chromium.org changed reviewers:
+ peter@chromium.org

[ananta, 2016-06-03 22:48:26]

+peter for content\shell owners

[Peter Beverloo, 2016-06-03 23:00:47]

On 2016/06/03 22:48:26, ananta wrote:
> +peter for content\shell owners

lgtm

[ananta, 2016-06-03 23:26:46]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2016-06-03 23:27:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2031833002/240001

[commit-bot: I haz the power, 2016-06-04 00:49:30]

Description was changed from

==========
Remove FilePath usage from the CrashReporterClient interface on Windows.

The CrashReporterClient implementation on Windows which is implemented by
the ChromeCrashReporterClient class will eventually move into chrome_elf
which loads very early in the chrome process. This requires it to not
depend on anything other than kernel32.dll and advapi32.dll.

Depending on base::FilePath pulls in FileUtil which on Windows brings with
it dependencies on message loop etc which won't work in chrome_elf.
Additionally the ChromeCrashReporterClient class currently depends on
content for constants, etc.

I defined these constants in the install_static library along with TODOs
to unify them. I plan to do that after finishing up the work for
chrome_elf.

The changes in this patch are as below:-
1. Remove FilePath from the CrashReporterClient functions on Windows.
2. Use the constants from install_static instead of those from content
   and base::Env.
3. Remove usage of base::Version from ChromeCrashReporterClient as that
   pulls in base logging which is not good for us.
4. Replace DCHECKs with asserts in ChromeCrashReporterClient

BUG=604923
==========

to

==========
Remove FilePath usage from the CrashReporterClient interface on Windows.

The CrashReporterClient implementation on Windows which is implemented by
the ChromeCrashReporterClient class will eventually move into chrome_elf
which loads very early in the chrome process. This requires it to not
depend on anything other than kernel32.dll and advapi32.dll.

Depending on base::FilePath pulls in FileUtil which on Windows brings with
it dependencies on message loop etc which won't work in chrome_elf.
Additionally the ChromeCrashReporterClient class currently depends on
content for constants, etc.

I defined these constants in the install_static library along with TODOs
to unify them. I plan to do that after finishing up the work for
chrome_elf.

The changes in this patch are as below:-
1. Remove FilePath from the CrashReporterClient functions on Windows.
2. Use the constants from install_static instead of those from content
   and base::Env.
3. Remove usage of base::Version from ChromeCrashReporterClient as that
   pulls in base logging which is not good for us.
4. Replace DCHECKs with asserts in ChromeCrashReporterClient

BUG=604923
==========

[commit-bot: I haz the power, 2016-06-04 00:49:31]

Committed patchset #13 (id:240001)

[commit-bot: I haz the power, 2016-06-04 00:51:53]

Description was changed from

==========
Remove FilePath usage from the CrashReporterClient interface on Windows.

The CrashReporterClient implementation on Windows which is implemented by
the ChromeCrashReporterClient class will eventually move into chrome_elf
which loads very early in the chrome process. This requires it to not
depend on anything other than kernel32.dll and advapi32.dll.

Depending on base::FilePath pulls in FileUtil which on Windows brings with
it dependencies on message loop etc which won't work in chrome_elf.
Additionally the ChromeCrashReporterClient class currently depends on
content for constants, etc.

I defined these constants in the install_static library along with TODOs
to unify them. I plan to do that after finishing up the work for
chrome_elf.

The changes in this patch are as below:-
1. Remove FilePath from the CrashReporterClient functions on Windows.
2. Use the constants from install_static instead of those from content
   and base::Env.
3. Remove usage of base::Version from ChromeCrashReporterClient as that
   pulls in base logging which is not good for us.
4. Replace DCHECKs with asserts in ChromeCrashReporterClient

BUG=604923
==========

to

==========
Remove FilePath usage from the CrashReporterClient interface on Windows.

The CrashReporterClient implementation on Windows which is implemented by
the ChromeCrashReporterClient class will eventually move into chrome_elf
which loads very early in the chrome process. This requires it to not
depend on anything other than kernel32.dll and advapi32.dll.

Depending on base::FilePath pulls in FileUtil which on Windows brings with
it dependencies on message loop etc which won't work in chrome_elf.
Additionally the ChromeCrashReporterClient class currently depends on
content for constants, etc.

I defined these constants in the install_static library along with TODOs
to unify them. I plan to do that after finishing up the work for
chrome_elf.

The changes in this patch are as below:-
1. Remove FilePath from the CrashReporterClient functions on Windows.
2. Use the constants from install_static instead of those from content
   and base::Env.
3. Remove usage of base::Version from ChromeCrashReporterClient as that
   pulls in base logging which is not good for us.
4. Replace DCHECKs with asserts in ChromeCrashReporterClient

BUG=604923

Committed: https://crrev.com/e76a92ef5942fe99139ae02e7dc5162dc0b24358
Cr-Commit-Position: refs/heads/master@{#397865}
==========

[commit-bot: I haz the power, 2016-06-04 00:51:55]

Patchset 13 (id:??) landed as
https://crrev.com/e76a92ef5942fe99139ae02e7dc5162dc0b24358
Cr-Commit-Position: refs/heads/master@{#397865}