Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2848683002: Chrome Cleaner UI: Rename SRT to ChromeCleaner (Closed)

Created:
3 years, 7 months ago by alito
Modified:
3 years, 7 months ago
Reviewers:
csharp, sky
CC:
chromium-reviews, vakh+watch_chromium.org, joenotcharles+watch_chromium.org, tfarina, grt+watch_chromium.org, timvolodine, csharp+watch_chromium.org, alito+watch_chromium.org, ftirelo+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Chrome Cleaner UI: Rename SRT to ChromeCleaner BUG=690020 patch from issue 2847643002 at patchset 20001 (http://crrev.com/2847643002#ps20001) Review-Url: https://codereview.chromium.org/2848683002 Cr-Commit-Position: refs/heads/master@{#468169} Committed: https://chromium.googlesource.com/chromium/src/+/f8f753f6d16087b221047b60ff600bb80fe9f3c1

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -465 lines) Patch
M chrome/browser/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/safe_browsing/chrome_cleaner_dialog_controller.h View 1 3 chunks +7 lines, -7 lines 0 comments Download
A + chrome/browser/safe_browsing/chrome_cleaner_dialog_controller.cc View 1 2 chunks +13 lines, -13 lines 0 comments Download
D chrome/browser/safe_browsing/srt_prompt_controller.h View 1 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/browser/safe_browsing/srt_prompt_controller.cc View 1 1 chunk +0 lines, -67 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_dialogs.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
A + chrome/browser/ui/views/chrome_cleaner_dialog.h View 1 3 chunks +18 lines, -17 lines 0 comments Download
A + chrome/browser/ui/views/chrome_cleaner_dialog.cc View 1 9 chunks +22 lines, -20 lines 0 comments Download
A + chrome/browser/ui/views/chrome_cleaner_dialog_browsertest.cc View 2 chunks +8 lines, -7 lines 0 comments Download
D chrome/browser/ui/views/srt_prompt_dialog.h View 1 1 chunk +0 lines, -72 lines 0 comments Download
D chrome/browser/ui/views/srt_prompt_dialog.cc View 1 1 chunk +0 lines, -155 lines 0 comments Download
D chrome/browser/ui/views/srt_prompt_dialog_browsertest.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M chrome/test/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
alito
Renames UI classes from SRT... -> ChromeCleaner. PTAL.
3 years, 7 months ago (2017-04-27 18:28:59 UTC) #2
sky
IMO ChromeCleaner is only marginally better. Isn't this more of a MalwareRemover?
3 years, 7 months ago (2017-04-27 22:19:04 UTC) #3
alito
The tool's official name is "Chrome Cleanup Tool" (see https://www.google.com/chrome/cleanup-tool/) and as part of implementing ...
3 years, 7 months ago (2017-04-27 22:29:09 UTC) #4
sky
ChromeCleaner it is. LGTM
3 years, 7 months ago (2017-04-27 22:50:36 UTC) #5
csharp
lgtm
3 years, 7 months ago (2017-04-28 21:42:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848683002/20001
3 years, 7 months ago (2017-04-28 21:42:39 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 23:04:30 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f8f753f6d16087b221047b60ff60...

Powered by Google App Engine
This is Rietveld 408576698